Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nixpkgs to 20.09, rules_haskell to 0.13, rules_nixpkgs to 0.7 #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade nixpkgs to 20.09, rules_haskell to 0.13, rules_nixpkgs to 0.7 #2

wants to merge 2 commits into from

Conversation

avdv
Copy link

@avdv avdv commented Nov 25, 2020

  • remove package override for brittany, this was fixed in nixpkgs
  • fix compiler errors due to unused imports
  • fix compilation due to API changes in xml-conduit 1.9.0.0
  • upgrade GHC to version 8.8.4

@robinp
Copy link
Member

robinp commented Dec 2, 2020

Thank you for the update! Anything else to add to this PR, since I see it is marked as draft?

avdv
avdv commented Dec 2, 2020
View reviewed changes
WORKSPACE

rules_haskell_toolchains(version = "8.6.5")
#rules_haskell_toolchains(version = "8.8.4")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to remove those lines, otherwise it would not build... IIRC.

@avdv
Copy link
Author

avdv commented Dec 2, 2020

Thank you for the update! Anything else to add to this PR, since I see it is marked as draft?

I just wasn't sure about the lines I had to remove.. it's working fine for me.

BTW, thank you for this template, it was a tremendous learning resource for me! ❤️

@avdv avdv marked this pull request as ready for review December 2, 2020 22:21
@avdv avdv force-pushed the upgrade-nix-and-bazel-rules branch from 71697b3 to 5053f78 Compare December 2, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avdv @robinp