devices: Dell XPS 13 9345: Update with upstream dtb name #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravMurav
reviewed
Oct 18, 2024
src/devices/dell_xps_13_9345.c
Outdated
| @@ -24,7 +24,7 @@ static EFI_GUID dell_inc__xps_13_9345_hwids[] = { | |||
|
|
|||
| static struct device dell_inc__xps_13_9345_dev = { | |||
| .name = L"Dell Inc. XPS 13 9345", | |||
| .dtb = L"qcom\\x1e80100-dell-tributo-13.dtb", /* Tentative. */ | |||
| .dtb = L"qcom\\x1e80100-dell-xps13-9345.dtb", /* Tentative. */ | |||
There was a problem hiding this comment.
Oh! Seems like I've missed this when checking for merged dts a couple of days ago... Thanks for noticing and updating this!
Since the name is now canonical, let's drop the note here and also remove italic in the readme for it
Suggested change
| .dtb = L"qcom\\x1e80100-dell-xps13-9345.dtb", /* Tentative. */ | |
| .dtb = L"qcom\\x1e80100-dell-xps13-9345.dtb", |
There was a problem hiding this comment.
Ah yes. missed it.
According to latest series that got merged: https://lore.kernel.org/all/[email protected]/
alexVinarskis
force-pushed
the
pr_update_xps_9345_name
branch
from
bdda019 to
4034f39
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to latest series that got merged:
https://lore.kernel.org/all/[email protected]/