ProgramUpdater: do not swallow exceptions but log stacktrace to

investigate #297
Transkribus · Mar 9, 2020 · 20410da · 20410da
1 parent 14cb957
commit 20410da
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/main/java/eu/transkribus/swt_gui/dialogs/ProgramUpdaterDialog.java b/src/main/java/eu/transkribus/swt_gui/dialogs/ProgramUpdaterDialog.java
@@ -310,6 +310,7 @@ private static boolean downloadUpdate(Shell parent, final ProgramPackageFile f,
 					try {
 						PROGRAM_UPDATER.downloadUpdate(downloadFile, f, monitor, downloadAll);
 					} catch (Exception e) {
+						logger.error("Program update could not be downloaded.", e);
 						throw new InvocationTargetException(e);
 					}
 				}
@@ -503,7 +504,9 @@ public static void checkForUpdatesDialog(Shell parent, String version, Date time
 			catch (IOException e) {
 				if (!e.getMessage().equals("stream is closed")) {
 					TrpMainWidget.getInstance().onError("IO-Error during update", "Error during update: \n\n"+e.getMessage(), e);	
-				}	
+				} else {
+					logger.error("Program update could not be downloaded or installed.", e);
+				}
 			}
 			catch (Throwable e) {
 				TrpMainWidget.getInstance().onError("Error during update", "Error during update: \n\n"+e.getMessage(), e);

diff --git a/src/main/java/eu/transkribus/swt_gui/mainwidget/TrpMainWidget.java b/src/main/java/eu/transkribus/swt_gui/mainwidget/TrpMainWidget.java
@@ -4541,6 +4541,8 @@ public void showUpdateDialog(final String title, final String customMessage) {
 			} catch (IOException e) {
 				if (!e.getMessage().equals("stream is closed")) {
 					TrpMainWidget.getInstance().onError("IO-Error during update", "Error during update: \n\n" + e.getMessage(), e);
+				} else {
+					logger.error("Program update could not be downloaded or installed.", e);
 				}
 			} catch (Throwable e) {
 				TrpMainWidget.getInstance().onError("Error during update", "Error during update: \n\n" + e.getMessage(), e);