Fix that padding_side always defaults to "right" when no value is explicitly passed #814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when the user does not pass in an explicit value for default_padding_side, the tokenizer that is created/loaded for a model is always assigned the default value of "right", even when we load in a model from Huggingface whose tokenizer might already have a default_padding_side value assigned to it. There is an example of that in issue #801. Since this default value could differ from the global default value "right" in TransformerLens, this PR creates the following resolution order:
This works similarly to the way the defaulting of prepend_bos was changed in PR #775
Fixes #801
For the example used in Issue #801:
The output is now:
instead of:
I also fixed a little typo where an error message says that padding_side is set incorrectly although the assertion statement checks for the value of default_prepend_bos.
Type of change
Please delete options that are not relevant.
Checklist: