Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 [FEATUREBRANCH] replace md-bootstrap with regular bootstrap #2169

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 27, 2023

Bumps mdb-ui-kit from 6.4.2 to 7.0.0.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 27, 2023
@MrKrisKrisu
Copy link
Member

Migrating from v6.x.x to v7
After updating the MDB Standard from version 6 to 7, there is a lot of breaking changes that must be introduced in existing projects to keep them stable. These changes relate in particular to data attributes, events and method names, compiled file names.

We also made some changes that are not visible to users but affect final product. We've changed bundler that compile files to Vite which allows smaller weight of the package after compilation.

We move from preparing files with compiled modules for every component to using ES modules. Our package will no longer include premade JavaScript modules. That change does not apply to plugins.

In the same fashion we won't include CSS modules anymore. To reduce bundle size of CSS in your project we recommend the use of PurgeCSS. Our tutorial for including PurgeCSS in yur project is available [here](https://mdbootstrap.com/docs/standard/getting-started/optimization/#section-purgecss).

Charts became separate file now which makes no difference when migrating to UMD format, but if user is going to use ES imports then charts needs to be imported from chart.es.min.js file as separate module.

https://mdbootstrap.com/docs/standard/getting-started/migration-guide/

Bumps [mdb-ui-kit](https://github.com/mdbootstrap/mdb-ui-kit) from 6.4.2 to 7.0.0.
- [Release notes](https://github.com/mdbootstrap/mdb-ui-kit/releases)
- [Commits](mdbootstrap/mdb-ui-kit@6.4.2...7.0.0)

---
updated-dependencies:
- dependency-name: mdb-ui-kit
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mdb-ui-kit-7.0.0 branch from ca83a6c to eb1fd07 Compare December 1, 2023 09:58
@HerrLevin
Copy link
Member

https://mdbootstrap.com/docs/standard/getting-started/migration-guide/#section-initialization

The migration guide is located here. I've made some changes so that mdb-ui-kit is initiated, but all these custom-js-tag-changes are driving me to move away from mdb-ui-kit. Who in their right mind wants to implement that?!

Just for reference (this probably shows more than actually needed but even half of it would be bad)
Screenshot 2023-12-01 at 11 33 45

@HerrLevin HerrLevin added the help wanted Extra attention is needed label Dec 4, 2023
@MrKrisKrisu
Copy link
Member

Let's switch to regular Bootstrap and enjoy the thrill of a 'simple' migration! 🤡

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 11, 2023

A newer version of mdb-ui-kit exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@MrKrisKrisu
Copy link
Member

Let's switch to regular Bootstrap and enjoy the thrill of a 'simple' migration! 🤡

For real - I would prefer to migrate to regular Bootstrap for a better long-term maintenance.
Any other opinions?

@MrKrisKrisu
Copy link
Member

Any other opinions?

Screenshot 2024-04-27 at 14 05 42

@HerrLevin
Copy link
Member

I think it'll be better to switch back to bootstrap. We would still need to adapt the css, because stock bs is not the design. (Or at least in our use case since we used mdb so much)

@MrKrisKrisu MrKrisKrisu changed the title ⬆️ Bump mdb-ui-kit from 6.4.2 to 7.0.0 🔥 replace md-bootstrap with regular bootstrap Jul 7, 2024
@MrKrisKrisu
Copy link
Member

This is used as a feature branch now. Replacing mdb with bootstrap is a bigger thing.

(create PRs to merge here and often merge the develop here until the port is finished)

@MrKrisKrisu MrKrisKrisu changed the title 🔥 replace md-bootstrap with regular bootstrap 🔥 [FEATUREBRANCH] replace md-bootstrap with regular bootstrap Jul 7, 2024
@MrKrisKrisu MrKrisKrisu marked this pull request as draft July 7, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change dependencies Pull requests that update a dependency file do not merge help wanted Extra attention is needed javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants