Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix Package #1888

Closed
wants to merge 6 commits into from
Closed

Nix Package #1888

wants to merge 6 commits into from

Conversation

NyCodeGHG
Copy link
Contributor

No description provided.

@NyCodeGHG NyCodeGHG force-pushed the feature/nix-package branch 11 times, most recently from cb994a6 to 47a9395 Compare September 2, 2023 20:56
@NyCodeGHG
Copy link
Contributor Author

i suggest that we register an organization on https://cachix.org to use their free tier for binary caching of our nix builds

@NyCodeGHG NyCodeGHG force-pushed the feature/nix-package branch 2 times, most recently from a6ce7d1 to 3f55900 Compare September 3, 2023 21:29
@NyCodeGHG
Copy link
Contributor Author

NyCodeGHG commented Sep 12, 2023 •
edited
Loading

So right now the package uses composer2nix, but there's a promising PR in nixpkgs which adds a more modern composer builder which only requires to keep a hash up to date, just like the npm builder.
It seems to work pretty well with traewelling's codebase, i think we can use that as soon as it's merged.

See https://github.com/NyCodeGHG/traewelling/blob/6bf60ad064ca49f3e811d22cf6e0b6f1237f97f8/nix/package/default.nix
See NixOS/nixpkgs#248184

@NyCodeGHG NyCodeGHG force-pushed the feature/nix-package branch 2 times, most recently from 16821f8 to 14350d6 Compare September 30, 2023 10:10
@NyCodeGHG NyCodeGHG force-pushed the feature/nix-package branch from 14350d6 to da06e75 Compare October 22, 2023 13:25
@NyCodeGHG NyCodeGHG force-pushed the feature/nix-package branch from da06e75 to 518c9a7 Compare October 22, 2023 14:37
@NyCodeGHG NyCodeGHG force-pushed the feature/nix-package branch from 518c9a7 to 52088e0 Compare October 22, 2023 17:22
@NyCodeGHG NyCodeGHG marked this pull request as ready for review October 22, 2023 17:25
@NyCodeGHG
Copy link
Contributor Author

NyCodeGHG commented Oct 22, 2023 •
edited
Loading

I think this is ready as is for now
edit: nevermind

I'll also add the automated hash update thing in another PR, the old workflow in this PR was far too complicated and probably horrible to maintain

@NyCodeGHG NyCodeGHG marked this pull request as draft October 22, 2023 17:30
@MrKrisKrisu MrKrisKrisu added the stale stale pr's that apparently are no longer maintained label Nov 21, 2023
@MrKrisKrisu
Copy link
Member

I noticed this PR has been in a draft state for a while. Are you currently actively working on this? If not, would it be possible to close this PR for now and perhaps reopen it later when you're ready to proceed? This helps in maintaining a clearer overview of ongoing projects.

Thank you for your attention to this matter. 😊

@NyCodeGHG
Copy link
Contributor Author

i'm not actively working on it, we can close it for now

@NyCodeGHG NyCodeGHG closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale stale pr's that apparently are no longer maintained
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NyCodeGHG @MrKrisKrisu