Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "local" connector type #206

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Add "local" connector type #206

merged 1 commit into from
Nov 18, 2019

Conversation

marquiswang
Copy link
Contributor

Fixes #195

Runs analysis tools on the HEAD of the local git repository and reports
to the log.

Allows someone to check for any comments before pushing to
Gerrit/Gitlab.

@codecov-io
Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #206 into master will decrease coverage by 0.4%.
The diff coverage is 58.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #206      +/-   ##
============================================
- Coverage     72.52%   72.11%   -0.41%     
- Complexity      592      601       +9     
============================================
  Files           142      145       +3     
  Lines          1889     1944      +55     
  Branches        121      127       +6     
============================================
+ Hits           1370     1402      +32     
- Misses          462      485      +23     
  Partials         57       57
Impacted Files Coverage Δ Complexity Δ
...c/main/java/pl/touk/sputnik/review/ReviewFile.java 92.3% <ø> (ø) 7 <0> (ø) ⬇️
...ain/java/pl/touk/sputnik/connector/Connectors.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/pl/touk/sputnik/configuration/GeneralOption.java 98.36% <100%> (ø) 3 <0> (ø) ⬇️
.../java/pl/touk/sputnik/connector/ConnectorType.java 66.66% <100%> (+2.38%) 3 <0> (ø) ⬇️
...uk/sputnik/connector/local/LocalFacadeBuilder.java 14.28% <14.28%> (ø) 1 <1> (?)
...ouk/sputnik/connector/local/LocalFacadeOutput.java 16.66% <16.66%> (ø) 1 <1> (?)
...touk/sputnik/connector/ConnectorFacadeFactory.java 57.14% <50%> (-1.2%) 3 <0> (ø)
...a/pl/touk/sputnik/connector/local/LocalFacade.java 71.79% <71.79%> (ø) 7 <7> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d3393...e1344e1. Read the comment docs.

Copy link
Collaborator

@SpOOnman SpOOnman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I have a few suggestions on this, please read them and tell me what you think.

@marquiswang
Copy link
Contributor Author

@SpOOnman Do you have any objections to #205? That one combined with this makes the maven plugin much more useful for me.

@marquiswang marquiswang requested a review from SpOOnman October 30, 2019 13:13
@marquiswang
Copy link
Contributor Author

I'm actually just realized that this patch doesn't actually work right. I'm using jgit wrong. It does the check on the uncommitted changes (since it does a git diff) whereas I need to do the equivalent of a git show. Will push a fix.

Runs analysis tools on the HEAD of the local git repository and reports
to the log.

Allows someone to check for any comments before pushing to
Gerrit/Gitlab.
@SpOOnman SpOOnman merged commit 04ca40c into TouK:master Nov 18, 2019
@SpOOnman
Copy link
Collaborator

Thank you for your submission! I'm sorry I was unavailable for so long. Great job! 👍

rufuslevi pushed a commit to rufuslevi/sputnik that referenced this pull request Mar 12, 2024
Add local connector type.

Runs analysis tools on the HEAD of the local git repository and reports
to the log. Fixes TouK#195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow running on commit instead of patchset
4 participants