-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "local" connector type #206
Conversation
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
============================================
- Coverage 72.52% 72.11% -0.41%
- Complexity 592 601 +9
============================================
Files 142 145 +3
Lines 1889 1944 +55
Branches 121 127 +6
============================================
+ Hits 1370 1402 +32
- Misses 462 485 +23
Partials 57 57
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! I have a few suggestions on this, please read them and tell me what you think.
src/main/java/pl/touk/sputnik/connector/ConnectorFacadeFactory.java
Outdated
Show resolved
Hide resolved
src/test/java/pl/touk/sputnik/connector/local/LocalFacadeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/pl/touk/sputnik/connector/local/LocalFacadeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/pl/touk/sputnik/connector/local/LocalFacadeTest.java
Outdated
Show resolved
Hide resolved
I'm actually just realized that this patch doesn't actually work right. I'm using jgit wrong. It does the check on the uncommitted changes (since it does a git diff) whereas I need to do the equivalent of a git show. Will push a fix. |
Runs analysis tools on the HEAD of the local git repository and reports to the log. Allows someone to check for any comments before pushing to Gerrit/Gitlab.
Thank you for your submission! I'm sorry I was unavailable for so long. Great job! 👍 |
Add local connector type. Runs analysis tools on the HEAD of the local git repository and reports to the log. Fixes TouK#195
Fixes #195
Runs analysis tools on the HEAD of the local git repository and reports
to the log.
Allows someone to check for any comments before pushing to
Gerrit/Gitlab.