Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1881][NU-1895] fix manual window size change and fix Maximum update depth exceeded #7254

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

Dzuming
Copy link
Contributor

@Dzuming Dzuming commented Nov 27, 2024

  • fix Maximum update depth exceeded
  • fix manual window size change

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Summary by CodeRabbit

  • Chores
    • Updated the version of the @touk/window-manager dependency to 1.9.1-beta.3.

NU-1895 fix Maximum update depth exceeded
@github-actions github-actions bot added client client main fe ui labels Nov 27, 2024
Copy link

coderabbitai bot commented Nov 27, 2024

📝 Walkthrough

Walkthrough

The changes in the pull request involve an update to the package.json file of the nussknacker-designer-client project. Specifically, the version of the @touk/window-manager dependency has been changed from 1.9.0 to 1.9.1-beta.3. This is the only modification made in the file, as no other dependencies or development dependencies were added, removed, or altered. The overall structure of the package.json file remains intact, including all existing configurations such as scripts, engines, license, and lint-staged settings. This update indicates a minor version increment for the specified dependency, reflecting a shift to a beta release.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant WindowManager

    Client->>WindowManager: Request version 1.9.1-beta.3
    WindowManager-->>Client: Provide updated functionality
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9d4f381 and 8855596.

⛔ Files ignored due to path filters (1)
  • designer/client/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • designer/client/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • designer/client/package.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Nov 27, 2024

updated: #7255
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@github-actions github-actions bot added the docs label Dec 5, 2024
@Dzuming Dzuming merged commit e5fbb42 into release/1.18 Dec 6, 2024
13 checks passed
@Dzuming Dzuming deleted the fix-errors-related-to-nk-windows branch December 6, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe docs ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants