Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1772] Fix line breaks in ScenarioActivities db table #7078

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

mgoworko
Copy link
Contributor

@mgoworko mgoworko commented Oct 24, 2024

Describe your changes

Plaintext activity details from old tables (for example for migration or automatic update) were migrated as part of the JSON in the new table. Newlines were incorrectly migrated as line breaks instead of \n in previous migrations.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@mgoworko mgoworko marked this pull request as ready for review October 24, 2024 12:16
Copy link
Contributor

@mk-software-pl mk-software-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a changelog for that? Or this is just a fix to some features not released, so there is no need to mention that?

@mgoworko mgoworko merged commit 1e89228 into staging Oct 25, 2024
17 checks passed
@mgoworko mgoworko deleted the NU-1772-scenario-activities-migration-fix branch October 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants