Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restored the oveview page in docs, Configuration section #7056

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

ZbyszekMM
Copy link
Contributor

@ZbyszekMM ZbyszekMM commented Oct 22, 2024

  1. Changed page title Common -> Miscellaneous. This page contains env vars only - although it is "common", it is not the stuff which you would normally expect on such a page. It is more a reference page of env vars.

  2. Unlike in all (?) other sections of documentation, the "main" Configuration docs page has both content ("Overview") and navigation tiles. Because other "non leaf" documentation pages do not contain content other than navigation tiles, in the extreme case, one may miss this documentation.

Currently:
image

Intended:
image

@github-actions github-actions bot added the docs label Oct 22, 2024
@ZbyszekMM ZbyszekMM requested a review from Dzuming October 22, 2024 10:42
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZbyszekMM ZbyszekMM merged commit b35d2df into staging Oct 22, 2024
1 check passed
@ZbyszekMM ZbyszekMM deleted the restore-overview-page-in-configuration-docs branch October 22, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants