Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview/nu 1778 activities #7004

Closed
wants to merge 192 commits into from
Closed

Preview/nu 1778 activities #7004

wants to merge 192 commits into from

Conversation

Dzuming
Copy link
Contributor

@Dzuming Dzuming commented Oct 10, 2024

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

…nt-crud

# Conflicts:
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #0.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #1.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #2.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #3.png
#	designer/client/src/components/modals/AddCommentDialog.tsx
#	designer/client/src/components/toolbars/activities/ActivitiesPanelRow.tsx
#	designer/client/src/components/toolbars/activities/ActivityPanelRowItem/ActivityItem.tsx
#	designer/client/src/components/toolbars/activities/ActivityPanelRowItem/ActivityItemHeader.tsx
#	designer/client/src/components/toolbars/activities/types.ts
#	designer/client/src/components/toolbars/activities/useActivitiesSearch.ts
#	designer/client/src/http/HttpService.ts
#	designer/client/src/windowManager/ContentGetter.tsx
#	designer/client/src/windowManager/WindowKind.tsx
# Conflicts:
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #0.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #1.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #2.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #3.png
…preview/NU-1778-activities

# Conflicts:
#	designer/client/src/components/toolbars/activities/ActivitiesPanelRow.tsx
#	designer/client/src/components/toolbars/activities/ActivityPanelRowItem/ActivityItem.tsx
#	designer/client/src/components/toolbars/activities/ActivityPanelRowItem/ActivityItemHeader.tsx
#	designer/client/src/http/HttpService.ts
… preview/NU-1778-activities

# Conflicts:
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #1.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #2.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Activities should display activities #3.png
@github-actions github-actions bot removed the docs label Oct 24, 2024
Dzuming and others added 16 commits October 24, 2024 14:03
# Conflicts:
#	designer/client/src/components/modals/ModifyExistingCommentDialog.tsx
#	designer/client/src/components/toolbars/activities/ActivityPanelRowItem/ActivityItemComment.tsx
#	designer/client/src/components/toolbars/activities/ActivityPanelRowItem/ActivityItemCommentModify.tsx
#	designer/client/src/components/toolbars/activities/ActivityPanelRowItem/ActivityItemHeader.tsx
#	designer/client/src/http/HttpService.ts
@github-actions github-actions bot added the docs label Oct 28, 2024
@github-actions github-actions bot removed the docs label Oct 28, 2024
@github-actions github-actions bot removed client client main fe ui labels Oct 28, 2024
@Dzuming Dzuming closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants