Weaker typing for input parameters in open api enrichers #6800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls change pr title to sth more descriptive |
raphaelsolarski
approved these changes
Sep 12, 2024
vder
changed the title
vder
force-pushed
the
list-of-object-with-optional-fields-in-openApi
branch
from
b50dfd7 to
3090d4c
Compare
|
created: #6868 |
vder
force-pushed
the
list-of-object-with-optional-fields-in-openApi
branch
from
3090d4c to
1e99fe1
Compare
vder
force-pushed
the
list-of-object-with-optional-fields-in-openApi
branch
from
1e99fe1 to
0c5ee69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I ve addend single test that shows the problem introduced with 1.17 version. In cases when openApi enricher accepts list of objects with optional parameters, these 'optionals' are obligatory right now. When we omit one we receive error ExpressionParserCompilationError(Bad expression type(...)