Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1805] Scenario labels support #6766

Merged
merged 37 commits into from
Sep 18, 2024
Merged

Conversation

mateuszkp96
Copy link
Contributor

Describe your changes

Scenario labels support including:
Filtering scenario list by labels:
image
image

Adding labels to scenario;
image
image
image
image
image

Labels validation:
image
Labels validation for saved scenarios:
image

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Copy link
Contributor

github-actions bot commented Sep 5, 2024

created: #6903
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@Dzuming
Copy link
Contributor

Dzuming commented Sep 6, 2024

I have a few general UX comments:

  1. Maybe we can just hide this field from details when there is no label defined?
image
  1. I'm able to add multiple tags with the same name, also this sorting is "strange" IMO because i would expect that the newest item would appear at the end of the tags,
Screen.Recording.2024-09-06.at.14.57.26.mov

Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as we discussed you can also add e2e test for this functionality

@github-actions github-actions bot added the docs label Sep 16, 2024
Co-authored-by: mateuszkp96 <[email protected]>
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateuszkp96 mateuszkp96 changed the title Scenario labels support [NU-1805] Scenario labels support Sep 18, 2024
@mateuszkp96 mateuszkp96 requested a review from mslabek September 18, 2024 13:16
Co-authored-by: mateuszkp96 <[email protected]>
Copy link
Member

@mslabek mslabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great job 👍

@mateuszkp96 mateuszkp96 merged commit 3f1e660 into staging Sep 18, 2024
18 checks passed
@mateuszkp96 mateuszkp96 deleted the scenario-labels-support branch September 18, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants