-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NU-1805] Scenario labels support #6766
Conversation
created: #6903 |
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/scenarioDetails/ScenarioLabels.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as we discussed you can also add e2e test for this functionality
Co-authored-by: mateuszkp96 <[email protected]>
Co-authored-by: mateuszkp96 <[email protected]>
designer/server/src/main/scala/pl/touk/nussknacker/ui/validation/ScenarioLabelsValidator.scala
Show resolved
Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/validation/UIProcessValidator.scala
Outdated
Show resolved
Hide resolved
...ner/server/src/main/scala/pl/touk/nussknacker/ui/api/description/MigrationApiEndpoints.scala
Show resolved
Hide resolved
...stmodel/src/main/scala/pl/touk/nussknacker/restmodel/validation/PrettyValidationErrors.scala
Outdated
Show resolved
Hide resolved
...erver/src/main/scala/pl/touk/nussknacker/ui/api/description/ScenarioLabelsApiEndpoints.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: mateuszkp96 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, great job 👍
Describe your changes
Scenario labels support including:
Filtering scenario list by labels:
Adding labels to scenario;
Labels validation:
Labels validation for saved scenarios:
Checklist before merge