Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nu-1780] Add advanced search options #6700

Merged
merged 9 commits into from
Sep 13, 2024

Conversation

DeamonDev
Copy link
Contributor

@DeamonDev DeamonDev commented Aug 30, 2024

Describe your changes

I've expanded the scenario nodes search graph ability in Nussknacker designer. Now we are only able to search for simple phrase and this phrase will be searched on all the properties on all the nodes. For more demanding users I propose to expand this on the following semantics:

id:("id1","id2",...) description:("desc1", "desc2", ...) type:("t1", "t2", ...) paramName:("p1", "p2", ...) paramValue:("pv1", "pv2", ...) outputValue:("o1", "o2", ...) "edgeExpression:("e1", "e2", ...)

If any of these selectors occurs as the search input text, the expression is treated as AdvancedSearch and the filtering logic is specified as follows:

The search result n (a node) is present under advanced search request above if and only if all of the following conditions are met:

  • the id of the node n is one of: id1, id2, ...
  • the description of the node n is one of: desc1, desc2, ...
  • ...
  • the edgeExpression of the node n is one of e1, e2, ....

So from the logic POV it is conjunction of alternatives.

Remark: If some selector is not specified then it is not taken under consideration.
Remark II: In the form user may write values in the quotation marks or not. For example all of the "n1","n2", n1,n2 or even "n1",n2 will lead to the same query result.

From the UI perspective I propose to add such form in order to generate this search query:

image

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Verify that PR will be squashed during merge
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change

Copy link
Contributor

github-actions bot commented Aug 30, 2024

created: #6859
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@DeamonDev DeamonDev force-pushed the nu-1780-add-advanced-filter-search branch from 6e030c5 to 0c0ee71 Compare September 5, 2024 07:17
@DeamonDev DeamonDev force-pushed the nu-1780-add-advanced-filter-search branch 4 times, most recently from f35dff6 to cffb491 Compare September 5, 2024 11:58
@DeamonDev DeamonDev requested a review from Dzuming September 5, 2024 13:48
@DeamonDev DeamonDev force-pushed the nu-1780-add-advanced-filter-search branch 5 times, most recently from b175321 to 21eea47 Compare September 6, 2024 13:02
@DeamonDev DeamonDev marked this pull request as ready for review September 6, 2024 13:02
@DeamonDev DeamonDev force-pushed the nu-1780-add-advanced-filter-search branch 3 times, most recently from 644cf0d to d984547 Compare September 6, 2024 13:31
@DeamonDev DeamonDev force-pushed the nu-1780-add-advanced-filter-search branch from d984547 to 3c1fac8 Compare September 9, 2024 08:15
@Dzuming
Copy link
Contributor

Dzuming commented Sep 9, 2024

@DeamonDev It behaves strangely on page refresh, the panel's initial state is open and then, it's closed. Could we improve it?

Screen.Recording.2024-09-09.at.10.40.43.mov

@DeamonDev DeamonDev force-pushed the nu-1780-add-advanced-filter-search branch 4 times, most recently from 1c5a743 to c4694c8 Compare September 10, 2024 07:13
@DeamonDev DeamonDev force-pushed the nu-1780-add-advanced-filter-search branch 3 times, most recently from b194748 to 0be412b Compare September 10, 2024 14:48
@DeamonDev DeamonDev force-pushed the nu-1780-add-advanced-filter-search branch 4 times, most recently from f9c3027 to 64e668b Compare September 11, 2024 11:58
@DeamonDev DeamonDev force-pushed the nu-1780-add-advanced-filter-search branch 3 times, most recently from 7b5ad30 to f038c12 Compare September 12, 2024 11:04
@DeamonDev DeamonDev force-pushed the nu-1780-add-advanced-filter-search branch from e8d37ad to d254663 Compare September 12, 2024 15:09
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeamonDev DeamonDev merged commit def9d3b into staging Sep 13, 2024
12 of 13 checks passed
@DeamonDev DeamonDev deleted the nu-1780-add-advanced-filter-search branch September 13, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants