-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nu-1780] Add advanced search options #6700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
from
August 30, 2024 12:18
65330a5
to
6e030c5
Compare
created: #6859 |
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
from
September 5, 2024 07:17
6e030c5
to
0c0ee71
Compare
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
4 times, most recently
from
September 5, 2024 11:58
f35dff6
to
cffb491
Compare
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
5 times, most recently
from
September 6, 2024 13:02
b175321
to
21eea47
Compare
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
3 times, most recently
from
September 6, 2024 13:31
644cf0d
to
d984547
Compare
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
from
September 9, 2024 08:15
d984547
to
3c1fac8
Compare
@DeamonDev It behaves strangely on page refresh, the panel's initial state is open and then, it's closed. Could we improve it? Screen.Recording.2024-09-09.at.10.40.43.mov |
Dzuming
requested changes
Sep 9, 2024
designer/client/src/components/toolbars/search/AdvancedSearchOptions.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/search/AdvancedSearchOptions.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/search/AdvancedSearchOptions.tsx
Outdated
Show resolved
Hide resolved
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
4 times, most recently
from
September 10, 2024 07:13
1c5a743
to
c4694c8
Compare
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
3 times, most recently
from
September 10, 2024 14:48
b194748
to
0be412b
Compare
Dzuming
requested changes
Sep 11, 2024
designer/client/src/components/toolbars/search/AdvancedSearchFilters.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/search/AdvancedSearchFilters.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/search/AdvancedSearchFilters.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/search/AdvancedSearchFilters.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/search/AdvancedSearchFilters.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/search/AdvancedSearchFilters.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/toolbars/search/AdvancedSearchFilters.tsx
Show resolved
Hide resolved
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
4 times, most recently
from
September 11, 2024 11:58
f9c3027
to
64e668b
Compare
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
3 times, most recently
from
September 12, 2024 11:04
7b5ad30
to
f038c12
Compare
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
from
September 12, 2024 11:10
f038c12
to
e8d37ad
Compare
DeamonDev
force-pushed
the
nu-1780-add-advanced-filter-search
branch
from
September 12, 2024 15:09
e8d37ad
to
d254663
Compare
Dzuming
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: DeamonDev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I've expanded the scenario nodes search graph ability in Nussknacker designer. Now we are only able to search for simple phrase and this phrase will be searched on all the properties on all the nodes. For more demanding users I propose to expand this on the following semantics:
id:("id1","id2",...) description:("desc1", "desc2", ...) type:("t1", "t2", ...) paramName:("p1", "p2", ...) paramValue:("pv1", "pv2", ...) outputValue:("o1", "o2", ...) "edgeExpression:("e1", "e2", ...)
If any of these selectors occurs as the search input text, the expression is treated as
AdvancedSearch
and the filtering logic is specified as follows:The search result
n
(a node) is present under advanced search request above if and only if all of the following conditions are met:id
of the noden
is one of:id1, id2, ...
description
of the noden
is one of:desc1, desc2, ...
edgeExpression
of the noden
is one ofe1, e2, ...
.So from the logic POV it is conjunction of alternatives.
Remark: If some selector is not specified then it is not taken under consideration.
Remark II: In the form user may write values in the quotation marks or not. For example all of the
"n1","n2"
,n1,n2
or even"n1",n2
will lead to the same query result.From the UI perspective I propose to add such form in order to generate this search query:
Checklist before merge