Remove old dropdown compatibility code #1153
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As modern menus are now supported in all client flavours, our compatibility layer for new menu APIs and UIDropDownMenu driven menus is no longer required. The only things left for the compatibility layer are the dropdown button template itself, and the one utility function for opening a context menu. These are used too widely in the codebase at present and I don't want to unnecessarily replace these until a future expansion patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As modern menus are now supported in all client flavours, our compatibility layer for new menu APIs and UIDropDownMenu driven menus is no longer required.
The only things left for the compatibility layer are the dropdown button template itself, and the one utility function for opening a context menu. These are used too widely in the codebase at present and I don't want to unnecessarily replace these until a future expansion patch.