Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rune fountain webwalking + mapping #129

Closed
wants to merge 3 commits into from
Closed

Conversation

bainwc
Copy link

@bainwc bainwc commented Jan 30, 2024

I hope I did things right, tried to follow as many instructions as I found for this pull request thing. I've added webwalking using the webber for Rune Fountain in wildy and I also made smaller maps for the fountain and edge bank in RSRegions. I am hoping to post a glory charging script to the discord once I'm done.

@Torwent
Copy link
Owner

Torwent commented Jan 30, 2024

Hey! Thanks for the PR.
I might be missing something but I don't see any change to the webgraph? What did you change exactly?
Also, as for the RSRegions added, the EDGEBANK once seems very unnecessary. Just use the EDGEVILLE one which shouldn't even exist either to be honest since there's so much in that area in the first place but just use that one. If you really need a smaller box use the box directly.

@bainwc
Copy link
Author

bainwc commented Jan 30, 2024

Thanks! I just assumed the smaller map was better for loading but I'll use EDGEVILLE instead. As for the webgraph, I created a web with webber and I believe it saved properly at line 125 and 302. They now have RuneFountain and Self.RUNEFOUNTAIN := [8633, 797], respectively.

@Torwent
Copy link
Owner

Torwent commented Jan 31, 2024

Loading a smaller box is more performant yes but it will not be noticeable st all in this case where the difference in size is not that big. You also get the risk of accidentally walking outside it and get completely lost.
If for some reason you really need that extra performance, you can always just use the box directly in walker.

It does not, the webgraph seems to be unchanged.
But don't worry, I'll add it soon.

@Torwent
Copy link
Owner

Torwent commented Jan 31, 2024

Alright, this is added! :)

@Torwent Torwent closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants