Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker action so that it can run test_version.py #298

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

lauramurgatroyd
Copy link
Member

@lauramurgatroyd lauramurgatroyd commented Aug 3, 2022

Previously, the docker action skipped running the test_version.py test as this was failing.

@lauramurgatroyd
Copy link
Member Author

I have printed the contents of the folder where the package gets installed and I can see it contains the version.py file, so that is definitely being made.
https://github.com/vais-ral/CILViewer/runs/7655965740?check_suite_focus=true#step:5:16
I was wondering if it was a permissions issue - as that file gets created by the setup.py but in that print, it shows the permissions to be the same as for the other cilviewer files.

I tested creating an environment locally from that environment.yml that the docker uses, and then pip installing and running the tests with pytest and I had no issues.

I don't understand this at all.

@lauramurgatroyd
Copy link
Member Author

The only other thing I can think to do is have this action run after the conda action and install the viewer from the built conda package artifact

@paskino
Copy link
Collaborator

paskino commented Aug 4, 2022

It looks like python does not find the file.
My thoughts was "wrong python". However, one can see that the rest of the tests work. Really weird.

@lauramurgatroyd lauramurgatroyd added this to the Version 22.4 milestone Aug 4, 2022
@lauramurgatroyd
Copy link
Member Author

I made the action upload the artifact of the docker image, downloaded it, ran locally and the version test failed there too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants