Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pip to code at head #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

fcfort
Copy link

@fcfort fcfort commented Sep 7, 2021

Assigning the dota2 subprocess' stdout to subprocess.PIPE blocks all console logging. When stdout == subprocess.PIPE, the dota2 process will not write anything to its console logs, regardless of the value of the -console or -con_logfile or dota2 flags. My guess is that since nothing is consuming that pipe, the dota2 console ends up being blocked since it can't write anything to a pipe that isn't being consumed.

Tested via manual editing of the source code in my local workspace to verify what was happening.

@fcfort
Copy link
Author

fcfort commented Sep 8, 2021

Sorry, this turned out to be a red herring. The real issue is that the version on pip (https://pypi.org/project/dotaservice/0.3.9/) doesn't have commit 733db26. Is there any way to get an updated version on pip?

@fcfort fcfort changed the title Remove PIPEs for subprocess since it blocks console.log Update pip to code at head Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant