cr suggestions

TianlongLiang · Oct 11, 2024 · 2ff60a9 · 2ff60a9
1 parent 6b8fc70
commit 2ff60a9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/core/iwasm/common/wasm_loader_common.c b/core/iwasm/common/wasm_loader_common.c
@@ -104,9 +104,8 @@ wasm_table_check_flags(const uint8 table_flag, char *error_buf,
         }
 #if WASM_ENABLE_MEMORY64 == 0
         if (table_flag & TABLE64_FLAG) {
-            LOG_VERBOSE("table64 flag was found, please enable memory64");
             wasm_loader_set_error_buf(error_buf, error_buf_size,
-                                      "invalid limits flags", is_aot);
+                                      "invalid limits flags(table64 flag was found, please enable memory64)", is_aot);
             return false;
         }
 #endif

diff --git a/core/iwasm/compilation/aot_compiler.c b/core/iwasm/compilation/aot_compiler.c
@@ -149,14 +149,14 @@ aot_validate_wasm(AOTCompContext *comp_ctx)
     if (comp_ctx->pointer_size < sizeof(uint64)) {
         if (IS_MEMORY64) {
             aot_set_last_error(
-                "Compiling wasm64 to 32bit platform is not allowed");
+                "Compiling wasm64(contains i64 memory section) to 32bit platform is not allowed");
             return false;
         }
 
         for (uint32 i = 0; i < comp_ctx->comp_data->table_count; ++i) {
             if (IS_TABLE64(i)) {
                 aot_set_last_error(
-                    "Compiling wasm64 to 32bit platform is not allowed");
+                    "Compiling wasm64(contains i64 table section) to 32bit platform is not allowed");
                 return false;
             }
         }

diff --git a/core/iwasm/interpreter/wasm_loader.c b/core/iwasm/interpreter/wasm_loader.c
@@ -2569,8 +2569,7 @@ load_table_import(const uint8 **p_buf, const uint8 *buf_end,
     read_leb_uint32(p, p_end, table_flag);
     is_table64 = table_flag & TABLE64_FLAG;
     if (p - p_org > 1) {
-        LOG_VERBOSE("integer representation too long");
-        set_error_buf(error_buf, error_buf_size, "invalid limits flags");
+        set_error_buf(error_buf, error_buf_size, "invalid table limits flags(integer representation too long)");
         return false;
     }
 
@@ -3092,8 +3091,7 @@ load_table(const uint8 **p_buf, const uint8 *buf_end, WASMModule *module,
     read_leb_uint32(p, p_end, table->table_type.flags);
     is_table64 = table->table_type.flags & TABLE64_FLAG;
     if (p - p_org > 1) {
-        LOG_VERBOSE("integer representation too long");
-        set_error_buf(error_buf, error_buf_size, "invalid limits flags");
+        set_error_buf(error_buf, error_buf_size, "invalid table limits flags(integer representation too long)");
         return false;
     }