Skip to content

Commit

Permalink
Removed unnecessary gcov source file filtering
Browse files Browse the repository at this point in the history
Other previous fixes and improvements prevent anything but release source files from being compiled with coverage
  • Loading branch information
mkarlesky committed Oct 6, 2023
1 parent 26ec7af commit 255f3df
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
9 changes: 1 addition & 8 deletions lib/ceedling/project_config_manager.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,7 @@ def merge_options(config_hash, option_filepath)
config_hash.deep_merge!( @yaml_wrapper.load( option_filepath ) )
end


def filter_internal_sources(sources)
filtered_sources = sources.clone
filtered_sources.delete_if { |item| item =~ /#{CMOCK_MOCK_PREFIX}.+#{Regexp.escape(EXTENSION_SOURCE)}$/ }
filtered_sources.delete_if { |item| item =~ /#{VENDORS_FILES.map{|source| '\b' + Regexp.escape(source.ext(EXTENSION_SOURCE)) + '\b'}.join('|')}$/ }
return filtered_sources
end


def process_release_config_change
# has project configuration changed since last release build
@release_config_changed = @cacheinator.diff_cached_release_config?( @config_hash )
Expand Down
1 change: 0 additions & 1 deletion plugins/gcov/lib/gcov.rb
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ def report_per_file_coverage_results()
heading = @ceedling[:plugin_reportinator].generate_heading( test )
@ceedling[:streaminator].stdout_puts(heading)

sources = @ceedling[:project_config_manager].filter_internal_sources(sources)
sources.each do |source|
filename = File.basename(source)
name = filename.ext('')
Expand Down

0 comments on commit 255f3df

Please sign in to comment.