Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-668 Removed the analytics service #95

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

RishiDiwanTT
Copy link
Contributor

Description

Removed the analytics service tabs from the System Configuration page.
These are no longer required as the CM will now configure the analytics without user interaction.

⚠️ Unit tests did not run successfully locally, but neither does the main branch.

Motivation and Context

The refactored analytics on the CM no longer require the Admin UI to control the "settings".

How Has This Been Tested?

Manually tested the removal and lack of API requests to the CM API.
This only affects the System Configuration page.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@RishiDiwanTT RishiDiwanTT requested a review from a team November 2, 2023 10:46
@RishiDiwanTT RishiDiwanTT self-assigned this Nov 2, 2023
@jonathangreen jonathangreen self-requested a review November 4, 2023 13:16
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@RishiDiwanTT RishiDiwanTT merged commit 28a75ef into main Nov 6, 2023
1 check passed
@RishiDiwanTT RishiDiwanTT deleted the feature/remove-analytics branch November 6, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants