Remove max_cache_age parameter (PP-1962) #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code was doing some questionable things to add the
max_cache_age
parameter to URLs. In PP-1962 I found this is causing some issues. We could do some work to fix up how we include the parameter in URLs, but since we are no longer using this parameter in the CM, it doesn't seem worth including it.Motivation and Context
Issues I was seeing with this code:
http://localhost:6500/admin/web/collection/GA0011%3Fmax_cache_age%3D0%26max_cache_age%3D0%26max_cache_age%3D0%26max_cache_age%3D0/book/GA0011%2FISBN%2F9780593457580/tab/lists
🤮http://localhost:6500/admin/web/lists/GA0011?max_cache_age=0&max_cache_age=0&max_cache_age=0&max_cache_age=0/create
which isn't a routable URL so it resulted in a white screen. The URL we wanted washttp://localhost:6500/admin/web/lists/GA0011/create
.max_cache_age
stuff fixed themIt seems like we might want to do some refactoring work to how the admin UI is generating URLs in the future, but this at least solves the issues I was seeing with the work lane editor screens.
How Has This Been Tested?
Checklist: