Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo-only header for QuickSight page. (PP-1720) #136

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Sep 25, 2024

Description

Enables a logo-only (no navigation) header and uses it for the QuickSight Dashboard page.

This PR also fixes up some of the testing infrastructure to allow the jest/react testing library framework tests to:

  • support tests that involve (sometimes transitively) the Footer component (by adding the TOSContextProvider into the component wrapper utilities;
  • support tests involving the Header component -- specifically, loading the logo via require or import (by adding mock support for assets).

The key changes are in:

  • src/components/Header.tsx
  • src/components/QuicksightDashboardPage.tsx
  • tests/jest/components/QuicksightDashboard.test.tsx

Motivation and Context

  • Reduce user confusion and accidental navigation.
  • Help prevent unnecessary consumption of QuickSight sessions.

[ Jira PP-1720]

How Has This Been Tested?

  • Manual local testing, using a stand-in page to avoid using up QuickSight sessions.
  • Tests pass locally.
  • CI tests for branch pass.

Checklist:

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from ray-lee September 25, 2024 15:59
Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tdilauro tdilauro merged commit 2dba4e5 into main Sep 27, 2024
1 check passed
@tdilauro tdilauro deleted the chore/logo-only-header-for-quicksight-page branch September 27, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants