Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings menu items unavailable when none already selected. (PP-1022) #103

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Feb 29, 2024

Description

  • Fixes a check and a default value in the code that filters already-selected options from the list available options for menu settings.
  • Adds a test that fails without this change, but passes with it.
  • Some typing fixes in unrelated parts of the affected file, in order to appease eslint.

Motivation and Context

The bug resulted in no options being available for selection if none were already selected.

[Jira PP-1022]

How Has This Been Tested?

  • Manually tested in a local development environment.
  • Added a new confirmation test.
  • Tests pass locally.

Checklist:

  • N/A I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro added the bug Something isn't working label Feb 29, 2024
Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments, but nothing is a blocker.

src/components/InputList.tsx Outdated Show resolved Hide resolved
src/components/InputList.tsx Outdated Show resolved Hide resolved
src/components/InputList.tsx Outdated Show resolved Hide resolved
src/components/__tests__/InputList-test.tsx Show resolved Hide resolved
@tdilauro tdilauro merged commit d899ec1 into main Feb 29, 2024
1 check passed
@tdilauro tdilauro deleted the bugfix/menu-options-lost-when-none-selected branch February 29, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants