Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sitewide settings configuration (PP-494) #101

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

jonathangreen
Copy link
Member

Description

Remove sitewide settings configuration since these have been moved to being configured via environment variables in ThePalaceProject/circulation#1648

Motivation and Context

Part of the work for PP-4

How Has This Been Tested?

Running tests

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎸

@jonathangreen jonathangreen merged commit 51ee64b into main Feb 7, 2024
1 check passed
@jonathangreen jonathangreen deleted the feature/remove-sitewide-settings branch February 7, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants