Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add design for video meta data #73

Merged
merged 5 commits into from
Jul 27, 2020
Merged

Add design for video meta data #73

merged 5 commits into from
Jul 27, 2020

Conversation

fredericobormann
Copy link
Contributor

@fredericobormann fredericobormann commented Jun 28, 2020 •
edited by jaagut
Loading

resolves #56

@fredericobormann fredericobormann marked this pull request as draft June 28, 2020 17:45
@fredericobormann fredericobormann marked this pull request as ready for review June 28, 2020 17:58
jaagut
jaagut approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@jaagut jaagut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks nice.

timonegk
timonegk reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@timonegk timonegk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very nice!

lecture2gether-vue/src/views/Room.vue Show resolved Hide resolved
lecture2gether-vue/src/components/VideoMetaData.vue Show resolved Hide resolved
@fredericobormann fredericobormann mentioned this pull request Jun 30, 2020
Open
lilioid
lilioid requested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@lilioid lilioid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the design and the feature is important.
I do have one small vue api recommendation though. Please address it.

lecture2gether-vue/src/components/VideoMetaData.vue Outdated Show resolved Hide resolved
@Flova Flova added enhancement New feature or request frontend labels Jul 10, 2020
@fredericobormann fredericobormann requested a review from lilioid July 24, 2020 16:27
@fredericobormann
Merge branch 'master' into add-video-meta-data-design
2e3f8f1 
# Conflicts:
#	lecture2gether-vue/src/components/Player.vue
#	lecture2gether-vue/src/views/Room.vue
@fredericobormann fredericobormann merged commit f063e01 into master Jul 27, 2020
@fredericobormann fredericobormann deleted the add-video-meta-data-design branch July 27, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timonegk timonegk timonegk left review comments

@jaagut jaagut jaagut approved these changes

@lilioid lilioid lilioid approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beautiful css for video meta data
5 participants
@fredericobormann @lilioid @timonegk @jaagut @Flova