Delay - Let's the movie start delayed after running command. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 9, 2022 11:34
… playback, by pausing when the player is created.
…play, fixes it not pausing on slow hardware (i.e. pi 4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does is add a new parameter, -d / --delay, which allows the movie to start very briefly before immediately pausing, giving a frozen frame to be displayed on screen. This is ideal to allow a VCR to catch up and not start recording without you, especially ideal for me since my VCR takes around 10-15 seconds to start recording.
The reason why I made this pause the video as oppose to just, not start the video yet, is to give a frozen frame on screen so that if the VCR starts recording before you expect it to, it doesn't show the Raspberry Pi's terminal screen in the recording, which although not the end of the world, isn't exactly what you wanna see when you play a VHS tape.
I personally like this because a couple of my movie files has my own self-created FBI warning screens n the such, and that's the frame that gets frozen on screen. And if the video starts with a fade-in, it just starts on a dark frame, giving another desirable result.
I'll admit it's a little bit jank since I didn't touch any of the capsender code, but I've tested this multiple times with different subtitle files and videos, and it all seems to check out fine. Additionally, this does work with -t/--starttime, though weirdly videos that use H.265 seem to act a little bit weird with that? H.264 works as expected though.