-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make ARCH_INDEPENDENT libraries to have CMake configs installed to share #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR, it looks great! just so I understand correctly, with this architecture-independent projects will be installed to CMAKE_INSTALL_DATADIR
, which is usually /usr/share
instead of the standard platform-dependent directory like /usr/lib
, correct?
Also should we add a test project to ensure this works as expected and doesn't break in the future?
@TheLartians Could you check it now, please? |
Yep. For example, check this bug: https://bugs.gentoo.org/show_bug.cgi?id=933479
Added, check please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates and adding a test case!
The main code changes look good, but there are some unrelated changes in the .gitignore
and unit testing, the latter apparently failing the CI run. Could you undo or address these changes?
Co-authored-by: Lars Melchior <[email protected]>
@TheLartians ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot for adding the changes and the test case! Also sorry for the long response times, currently don't have a lot of time for open-source work.
Feature published in |
overall right change
maybe fixes #30 if I understand the guys problem correctly