Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UADragonmarks): Add missing UA article #9

Merged
merged 8 commits into from
Nov 25, 2024

Conversation

revilowaldow
Copy link
Contributor

Might be nice for Plutonium to support named ability score choices like named additional spell choices:
(see Greater Dragonmark feat)
image
image

@revilowaldow
Copy link
Contributor Author

revilowaldow commented Nov 24, 2024

Additionally, the abbreviation for this article (UAD) conflicts with the abbreviation for both UA: Downtime and UA: Druid, which already conflict with each other.
Could move to UADra, UADow, UADru but that looks untidy...

@revilowaldow
Copy link
Contributor Author

revilowaldow commented Nov 24, 2024

I've further added the missing UA Magic Items of Eberron
Note that this is blocked behind schema permission for reqAttune and reqAttuneTags for baseitems
This feels odd but it's due to Armblades in the UA being baseitems rather than a magicvariant as per the final version
image

Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

named ability score choices

not a piece of UI I feel like overhauling at this exact moment, but will put in a feature request

Could move to UADra, UADow, UADru but that looks untidy...

seems tidy enough to me; UAD is pretty meaningless

maybe UADrgM, UADown, UADrui, or something along those "give it a bit of a hint" lines

Armblades

not a fan of the baseitem hack tbh; as I see it

pros:

  • can get specific variants

cons:

  • can't get armblades of homebrew items
  • can't get armblades of '24 items
  • the {@i any one-handed melee weapon} line is nasty
  • requires a cross-product explosion of reqAttuneTags when making specific variants
  • is hacky

I'm not convinced that pro is big enough to justify all the jank. As a Warforged enjoyer I'd rather have the full range of weapons on the table, and manually tack magic version stuff onto my sheet if I really need it later

maybe an Armblade magicvariant, plus Armblade (Vorpal) and Armblade (Vicious) magicvariants as a sampler, instead?

@revilowaldow
Copy link
Contributor Author

Cheers for feedback, will make changes tomorrow, or potentially later in the week.

Happy to make all the changes suggested and go with the magic variant style instead.

@TheGiddyLimit
Copy link
Owner

tyvm

@revilowaldow
Copy link
Contributor Author

Should be good to go :)

Copy link
Owner

@TheGiddyLimit TheGiddyLimit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely stuff

@TheGiddyLimit TheGiddyLimit merged commit 18c400c into TheGiddyLimit:master Nov 25, 2024
1 check passed
@revilowaldow revilowaldow deleted the Dragonmarks branch November 25, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants