Refactor mongo-seed to only use Dockerfile & remove it from docker-compose #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The mongo-seed service is removed from the docker-compose.yml file. - The mongo-seed service is defined solely in its respective Dockerfile present in the mongo-seed/Dockerfile directory. - The prepare_db target in the Makefile is modified to build the mongo-seed image and run it as a container with the required environment variables and network settings. The mongo-seed container is removed after the import activity is completed. Note: The server target in the Makefile still scales down the mongo-seed service by setting its count to 0 (--scale mongo-seed=0) since it is not defined in the docker-compose.yml file anymore.
|
Hi, I'm not able to successfully test this did you verified this in your local ? |
|
also i had to remove reference to mongo_seed in makefile's server |
keshav2010
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The server target in the Makefile still scales down the mongo-seed service by setting its count to 0 (--scale mongo-seed=0) since it is not defined in the docker-compose.yml file anymore.