Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mongo-seed to only use Dockerfile and remove service from docker-compose #10

Open
keshav2010 opened this issue Apr 3, 2023 · 1 comment
Labels
good first issue Good for newcomers help-wanted help from other contributors would be particularly welcome

Comments

@keshav2010
Copy link
Collaborator

keshav2010 commented Apr 3, 2023

We have a "mongo-seed" service defined in the docker-compose.yml file, which is responsible for populating/seeding the MongoDB container with sample data available in the mongo-seed/*.json files.

Changes are required as follows:

  1. Remove the mongo-seed service from docker-compose.yml and define it solely in its respective Dockerfile (present in the mongo-seed/Dockerfile directory).
  2. Modify the preparedb block in the Makefile to perform the import activity.

Another alternative could be to use some init script in Golang/Mongosh's JavaScript that performs this activity.

Both solutions are welcome.

@keshav2010 keshav2010 added help-wanted help from other contributors would be particularly welcome good first issue Good for newcomers labels Apr 3, 2023
@w3tsa
Copy link

w3tsa commented Apr 10, 2023

I have created a PR for this: Changes Made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help-wanted help from other contributors would be particularly welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants