-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dogm robot test #85
base: master
Are you sure you want to change the base?
Dogm robot test #85
Conversation
…, changed cmeke files for building with ros
@TheCodez can you check this out? There may be extra debug code somewhere. I create this PR manually deleting all changes that i need for my ROS node. |
@ShepelIlya Thank you. I will take a look as soon as possible. |
Nice -- I was seeing an occasional crash in CUDA but haven't been able to get to it. I ported your changes into my fork and things look stable with a small caveat -- I added a function to free the GridCellSoA in dogm.h/cu since the ROS functions/layers know nothing about CUDA and die a horrible death if cleanup isn't done. Looks like:
|
Yeah, i found it too later, but i forgot to update this PR. |
@idlebear have you seen a noticable runtime performance difference with SoA grid cells? @ShepelIlya no worries, I will include a memory leak fix once I have some more time to integrate your changes. |
So it's... slower? Here are the collected stats for a couple runs. I'm using a 100x100m grid with 0.25m resolution (cartesian) and 0.1m resolution (polar). Maybe extra allocs that are making the difference? Don't know without further digging. The third is without opengl...
This is the original view (video is in a non-standard res so it's probably squashed in your view): dogm-25m-1r-ros-opengl-orig.mp4Here's the SoA version (looks the same): dogm-25m-1r-ros-opengl-SoA.mp4And for completeness, polar->cartesian: dogm-25m-1r-ros-p2c-SoA.mp4I'm also seeing the artifacts in all versions... I can post the debug and release binaries later today when I get a chance -- got a preferred delivery mechanism? |
@idlebear I'm seeing no improvement either, which is unfortunate as I was hoping that this would get the performance closer to the paper. As for the the trails and noise, I think it will get a lot better once you increase the number of particles. Just upload the binaries here or in the discussion thread if possible. |
Yeah, looking at the profiler output, of those ~10mS, the biggest wins seem to be in processing the texture and particle assignment. It's a bit different with the car in motion, but those numbers are still fairly representative,. |
This changes comes from testing dogm on live robot at field conditions.
I tried to roughly group all my changes into several commits.