Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: How_to_Guides: Add page on Y2K38 #51

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

jsuhaas22
Copy link
Contributor

Y2K38 issue has been fixed in Scarthgap, but is still present in Kirkstone, and hence also in Kirkstone images of AM335x and AM437x. Since 9.3 release is going to be a Kirkstone one, add a How_to_Guide warning of the presence of this issue, and some solutions on how to deal with it.

@cshilwant
Copy link
Member

@jsuhaas22 Nitpick,

s/page/section & s/warning/section in commit message & title

@jsuhaas22 jsuhaas22 force-pushed the y2k38-documentation branch 2 times, most recently from b2822f6 to 7bc1e97 Compare November 26, 2024 09:18
cshilwant
cshilwant previously approved these changes Nov 26, 2024
Copy link
Member

@StaticRocket StaticRocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New file does not follow common section depth [1]. Also, shouldn't AM57X be updated here as well?

[1] https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections

Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New file does not follow common section depth [1]

[1] https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections

@jsuhaas22 This comment is still not addressed in your latest changes

Copy link

New warnings found with rstcheck:

source/linux/How_to_Guides/Target/How_to_fix_y2k38.rst:26: (WARNING/2) Title overline too short.

Y2K38 issue has been fixed in Scarthgap, but is still present in
Kirkstone, and hence also in Kirkstone images of AM335x and AM437x.
Since 9.3 release is going to be a Kirkstone one, add a How_to_Guide
section of the presence of this issue, and some solutions on how to
deal with it.

Signed-off-by: Suhaas Joshi <[email protected]>
@cshilwant cshilwant dismissed StaticRocket’s stale review November 28, 2024 13:38

PR updated by the author

@cshilwant cshilwant merged commit 7771478 into TexasInstruments:master Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants