Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CODEOWNERS file #31

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

cshilwant
Copy link
Member

Add CODEOWNERS file to define individuals or teams that are responsible for code in a repository.

Code owners will be automatically requested for review when someone opens a pull request that modifies code that they own.

Fixes #8

@cshilwant cshilwant requested review from praneethbajjuri, StaticRocket and a team November 1, 2024 02:07
@cshilwant cshilwant self-assigned this Nov 1, 2024
@cshilwant
Copy link
Member Author

cshilwant commented Nov 1, 2024

@DhruvaG2000 Please accept the invitation to get in GitHub TI organization.
Post which the error seen now would no longer be valid - https://github.com/TexasInstruments/processor-sdk-doc/pull/31/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7R29

Meanwhile, the PR is good for review & integration as GitHub is intelligent enough to auto detect
the addition of Dhruva in TI org & remove the warning

@praneethbajjuri
Copy link
Collaborator

@uditkumarti , @aniket-l please review

StaticRocket
StaticRocket previously approved these changes Nov 2, 2024
Copy link
Member

@StaticRocket StaticRocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this for now, though we should look into a more generic solution like:
https://github.com/dyladan/component-owners

At least until the following is addressed:
https://github.com/orgs/community/discussions/23042

Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK From my side to merge

.github/CODEOWNERS Outdated Show resolved Hide resolved
Add CODEOWNERS file to define individuals that
are responsible for any code in the repository.

Code owners will be automatically requested for review when
someone opens a pull request that modifies any code in the
repository.

Signed-off-by: Chirag Shilwant <[email protected]>
@cshilwant cshilwant merged commit 48459ff into TexasInstruments:master Nov 4, 2024
1 check passed
@cshilwant cshilwant deleted the feature/codeowners branch November 4, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a CODEOWNERS file to auto assign reviewers
6 participants