Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/lint collection #125

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/linux/Industrial_Protocols/PTP/_PTP.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1847,7 +1847,7 @@ Procedure
~~~~~~~~~

The script file
`setup\_hsr.sh <http://processors.wiki.ti.com/images/1/18/Setup_hsr.pdf>`_
`setup\_hsr.sh <http://processors.wiki.ti.com/images/1/18/Setup_hsr.pdf>`__
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StaticRocket, while unrelated to this PR, this link does not work anymore. @danish-ti, could you please identify the equivalent for this link and create a PR to fix the link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siddharth-Vadapalli-at-TI I don't think there is any equivalent for this link. To fix this script will need to be hosted somewhere and link to that should be added here. But as @cshilwant mentioned that this file is not used by any device, I think dropping this is the best option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danish-ti I was only referring to source/system/Demo_User_Guides/Servo_Drive_Demo_User_Guide.rst file to @StaticRocket - #125 (comment)

Not sure about source/linux/Industrial_Protocols/PTP/_PTP.rst

and clock configuration files e.g. dut_1_hsr_oc.cfg, dut_2_hsr_oc.cfg,
dut_3_hsr_oc.cfg (each identical, same as listed in
`PTP Redundancy <Industrial_Protocols_PTP.html#redundancy-hsr-prp>`__
Expand Down Expand Up @@ -1876,7 +1876,7 @@ section for HSR) will be used in the setup of the tests.

- Boot IDK into kernel prompt.

- Modify the top fields in `setup\_hsr.sh <http://processors.wiki.ti.com/images/1/18/Setup_hsr.pdf>`_
- Modify the top fields in `setup\_hsr.sh <http://processors.wiki.ti.com/images/1/18/Setup_hsr.pdf>`__
to reflect the HSR slave
ports' MAC addresses and IP address of the DUT's HSR interface. The
**ETHA** or **ETHB** fields may also need to be modified if an ICSS
Expand Down