-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the MMC documentation #114
Conversation
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring, added few suggestions
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Storage/MMC-SD.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All remaining open conversations have still not been addressed. Please review comments again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the last change request
Fix the MMC documentation in UG-Memory. The file has been patched up in a way that is uneccessarily difficult to browse. Fix up the documentation sections and whitespace. While we are here add additional necessary sections for MMC. Signed-off-by: Judith Mendez <[email protected]>
Fix the MMC documentation in MMC-SD. The file has been patched up in a way that is uneccessarily difficult to browse. Fix up the documentation sections and whitespace. While we are here add additional necessary sections for MMC. Signed-off-by: Judith Mendez <[email protected]>
Author has updated the PR
@praneethbajjuri / @r-vignesh / @bryanbrattlof for final review |
This PR has patches to refactor the MMC documentation. ATM the documentation is too difficult to parse and read. Fix indentation issues, update the code block sections, add additional missing sections, etc...