Skip to content

Commit

Permalink
PR Checker should check PR Link for DeveloperFixed
Browse files Browse the repository at this point in the history
  • Loading branch information
pthariensflame committed Dec 5, 2021
1 parent 38ba753 commit 67a0479
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions format_checker/pr_checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ def check_status_consistency(filename, row, i, log):
else:
check_pr_link(filename, row, i, log)

if row["Status"] == "DeveloperFixed":
# Should contain either no PR Link or a valid one
if not row["PR Link"] == "":
check_pr_link(filename, row, i, log)

if row["Status"] == "" and row["PR Link"] != "":
check_pr_link(filename, row, i, log)
log_std_error(filename, log, i, row, "Status should not be empty when a PR link is provided.")
Expand Down

0 comments on commit 67a0479

Please sign in to comment.