Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow debug to report multiple invocations #168

Merged
merged 4 commits into from
Aug 27, 2022
Merged

Allow debug to report multiple invocations #168

merged 4 commits into from
Aug 27, 2022

Conversation

kaiyaok2
Copy link
Contributor

@kaiyaok2 kaiyaok2 commented Aug 9, 2022

This PR addresses the idea in (#53) to report many invocations from all seeds that can reproduce error.
3 changes are made w.r.t the original PR:

  • Resolve code conflict with the latest master branch
  • If a test is ND (falsely identified as ID by NonDex, which is quite common), reportDebugInfo() , which subsequently calls failsWithConfig() can return null even if being run with the same "originally failing" configuration. Then, the list allFailingConfigurations can contain null entries, which causes NPE when iterating through the list. The solution is to add a null check to avoid NPE thrown by makeResultString().
  • The original PR did not add the results found by linear search to the output list. This PR corrects it.

@darko-marinov
Copy link
Contributor

The code looks good enough to me to merge so we can release sooner the next version of NonDex to support Java 9+.

Copy link
Contributor

@darko-marinov darko-marinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good enough to me to merge so we can release sooner the next version of NonDex to support Java 9+.

@darko-marinov darko-marinov merged commit fe85fb7 into TestingResearchIllinois:master Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants