-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add introductory panel and remove pop up card #692
base: master
Are you sure you want to change the base?
Add introductory panel and remove pop up card #692
Conversation
30e8d27
to
e7a697c
Compare
Hi @griseduardo, thanks for taking this one on. We haven't done a code review yet, but I just tested this PR out on the front and it looks really good! I think there is just one additional change that we should make based on front-end testing: once a user selects an option in the second drop down, the intro panel should automatically disappear and the list of filtered cards revealed. Otherwise, great work on this! |
Hello @rudokemper , thank you. |
Awesome! Looks great. One final thing I just noticed is that we may want to adapt to the mobile view. Would it be easy and possible to hide this panel for mobile, for the time being? (Mobile UI is due for a redesign, where we'll consider how to incorporate this panel differently.) |
Also, sorry I didn't catch your question about i18n on the other thread. I think what you did was fine; we have to do some i18n updates to a number of the other languages anyway. |
One question, do you want to hide the introductory panel and return the stories when in mobile? (like it was before my changes) |
Yeah, for the time being let's do that for Mobile. Since we have to do a redesign of the Mobile UI anyway. If you ended up doing some custom code for mobile specifically, please just comment that out so we can use it later. |
Ok, I updated to show the stories when in mobile device |
Thanks so much @griseduardo, I appreciate you iterating on this. @lauramosher @FeminismIsAwesome mind doing a code review on this one? |
Motivation:
Add introductory panel and remove right pop up card
Solution:
Issue:
#675
Opening page:
After button click:
PS: I updated all i18n languages using English