feat: 流程市场共享模板查看 #7626 #7630
Merged
feat: 流程市场共享模板查看 #7626 #7630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normal-wls
requested changes
Dec 5, 2024
gcloud/contrib/templatemaker/apis/drf/viewsets/template_marker.py
Outdated
Show resolved
Hide resolved
gcloud/contrib/templatemaker/apis/drf/viewsets/template_marker.py
Outdated
Show resolved
Hide resolved
gcloud/contrib/templatemaker/apis/drf/viewsets/template_marker.py
Outdated
Show resolved
Hide resolved
normal-wls
requested changes
Dec 5, 2024
normal-wls
reviewed
Dec 9, 2024
normal-wls
requested changes
Dec 9, 2024
normal-wls
requested changes
Dec 10, 2024
normal-wls
requested changes
Dec 12, 2024
normal-wls
requested changes
Dec 12, 2024
normal-wls
requested changes
Dec 12, 2024
normal-wls
requested changes
Dec 13, 2024
|
|
||
| def create_shared_record(self, project_id, market_record_id, template_ids, creator): | ||
| for template_id in template_ids: | ||
| existing_record, created = TemplateSharedRecord.objects.get_or_create( |
There was a problem hiding this comment.
这里要请求多次 db，在 model 操作上跟 update 应该是一套逻辑，建议写到 model manager 里面
| def update_shared_record(self, new_template_ids, market_record_id, project_id, creator): | ||
| market_record_id = int(market_record_id) | ||
|
|
||
| existing_records = TemplateSharedRecord.objects.filter( |
There was a problem hiding this comment.
直接从 market 拉取 template_ids 即可
| permission_classes = [permissions.IsAuthenticated, TemplatePreviewPermission] | ||
|
|
||
| def retrieve(self, request, *args, **kwargs): | ||
| request_serializer = TemplateProjectBaseSerializer(data=request.GET) |
| serializer_class = TemplatePreviewSerializer | ||
| permission_classes = [permissions.IsAuthenticated, TemplatePreviewPermission] | ||
|
|
||
| def retrieve(self, request, *args, **kwargs): |
There was a problem hiding this comment.
这里是 retrieve，前端调用的时候传的 id 是什么
| return Response({"result": True, "data": serializer.data, "code": err_code.SUCCESS.code}) | ||
|
|
||
|
|
||
| class SharedTemplateRecordsViewSet(viewsets.ViewSet): |
There was a problem hiding this comment.
这个视图，跟 TemplateSharedRecord 这个 model 看上去关系不大，后面调整一下相关的所有命名。SharedTemplateRecordsViewSet 的理解是对TemplateSharedRecord这个 model 的相关操作视图
| from gcloud.contrib.template_market.permission import TemplatePreviewPermission, SharedTemplateRecordPermission | ||
|
|
||
|
|
||
| class TemplatePreviewViewSet(viewsets.ViewSet): |
There was a problem hiding this comment.
这个后面改成 APIView，不是对某个资源的 curd
normal-wls
merged commit d9fc288
into
TencentBlueKing:feature_template_market_master
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.