Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

任务画布和状态API 标识跳过与重试次数 #6750

Closed
zyxazhang opened this issue May 18, 2023 · 2 comments · Fixed by #7126 or #7145
Closed

任务画布和状态API 标识跳过与重试次数 #6750

zyxazhang opened this issue May 18, 2023 · 2 comments · Fixed by #7126 or #7145
Assignees
@ZhuoZhuoCrayon @ywywZhou
Labels
stage/tested

Comments

@zyxazhang
Copy link
Contributor

zyxazhang commented May 18, 2023 •
edited by ecoli666
Loading

问题描述

  1. 任务执行时，画布标识了节点是否配置了重试、跳过。但执行阶段用户更关心的是基于配置产生的行为，例如自动重试了N次 和 采用何种方式跳过。而配置是流程管理者设定了，执行者无法干预，有地方能够看到配置即可

  2. 配置了自动重试的节点，在重试间隔期，任务不应该是 ”失败“状态。因为节点的执行并没有完结，并非静止的状态
    假设用户基于这个”失败“状态做一些处理，那么这种处理会和自动重试动作产生冲突

image

优化

画布优化

  1. 移除节点失败处理选项展示
  2. 在画布上增加手动重试和自动重试的次数，分开展示次数
  3. 区分“自动跳过”和“手动跳过”

image

节点详情优化

  1. 增加 失败 状态下的补充说明 ，补充重试次数
    image

任务状态API优化

  1. 增加一个字段，用于判断Failed的任务是否处于真正静止状态 （即已达到最大自动重试次数）
@zyxazhang
Copy link
Contributor Author

在taskflow/task_id接口中返回 running_count 这个对象字段，字段内容为
image

@ecoli666 ecoli666 changed the title 画布节点跳过与重试次数标识 任务画布标识跳过与重试次数 May 18, 2023
@ywywZhou ywywZhou self-assigned this Jun 29, 2023
@ecoli666 ecoli666 changed the title 任务画布标识跳过与重试次数 任务画布和状态API 标识跳过与重试次数 Sep 20, 2023
@ZhuoZhuoCrayon ZhuoZhuoCrayon linked a pull request Oct 16, 2023 that will close this issue
节点详情及任务状态 API 增加自动重试配置信息 #7126
Merged
@ZhuoZhuoCrayon
Copy link
Member

联调信息

taskflow/api/status/xx/?instance_id=xxx

增加 auto_retry_infos

企业微信截图_8306ac5b-09ea-4080-b984-dfddf0c46cc8

taskflow/api/node/detail/

增加 auto_retry_info

企业微信截图_151cd9f1-011a-41bd-bd68-093ddbbb7802

手动重试次数 = 节点重试总数(retry) - 自动重试次数(auto_retry_info.auto_retry_times)

@ywywZhou ywywZhou linked a pull request Oct 27, 2023 that will close this issue
节点&任务状态优化 #7145
Merged
@ecoli666 ecoli666 mentioned this issue Nov 7, 2023
Open
ywywZhou added a commit to ywywZhou/bk-sops that referenced this issue Jan 8, 2024
@ywywZhou
feat: 未选择任何节点时，添加一个错误message TencentBlueKing#6750
b233423
ywywZhou added a commit to ywywZhou/bk-sops that referenced this issue Jan 8, 2024
@ywywZhou
feat: 选择节点时隐藏节点重试/跳过标识 TencentBlueKing#6750
8c85994 
# Reviewed, transaction id: 1637
luofann pushed a commit that referenced this issue Jan 8, 2024
@ywywZhou
未选择任何节点时，添加一个错误message && 选择节点时隐藏节点重试/跳过标识 (#7287)
7f040c4 
* feat: 未选择任何节点时，添加一个错误message #6750

* feat: 选择节点时隐藏节点重试/跳过标识 #6750
# Reviewed, transaction id: 1637
ywywZhou added a commit to ywywZhou/bk-sops that referenced this issue Jan 8, 2024
@ywywZhou
feat: 未选择任何节点时，添加一个错误message TencentBlueKing#6750
56e23c2 
# Reviewed, transaction id: 1647
luofann pushed a commit that referenced this issue Jan 10, 2024
@ywywZhou @luofann
feat: 未选择任何节点时，添加一个错误message #6750
f789e53 
# Reviewed, transaction id: 1647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZhuoZhuoCrayon ZhuoZhuoCrayon

@ywywZhou ywywZhou

Labels
stage/tested
Projects
None yet
Milestone
No milestone
5 participants
@ZhuoZhuoCrayon @ecoli666 @MarinPeng @ywywZhou @zyxazhang