Added colorScheme to default signal payload #193
Merged
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeehut
reviewed
Nov 26, 2024
|
I decided against doing so for watchOS because this would distort the results. For visionOS this is the same tho if you prefer it to be that way, I will change that. |
|
@FPST-08 Hmm, I see your point. I guess the question is what one would want to learn from this info bit, especially for apps that are multi-platform (since single platform apps aren't affected). But I guess I'm on your side here. 🙌 |
|
@FPST-08 I'm happy to inform you that your change is now part of the new release 2.6.0 of our SDK! Thank you very much for your contribution! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is useful to automatically send the colorScheme of the app to TelemetryDeck.