Mark global navigation as @MainActor to avoid data-race safety issues #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2024
|
Fantastic work as always, and https://editorconfig.org is indeed very cool! |
winsmith
approved these changes
Aug 12, 2024
|
Awesome. Closing this as it's superseded by #174 which I just merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #172.
This can be considered a first step into #165 to make the SDK ready for Swift 6 mode. To make sure we keep the data-race safety for the navigation path, I've additionally turned on strict-concurrency-checking, which also gives us warnings for all the places that will become errors in Swift 6 mode.
Note that I have also added an
.editorconfigfile in this PR to codify the existing indentation config in the project. See my tweet to learn more about this new feature in Xcode 16: https://x.com/Jeehut/status/1817931035872751744