-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to check for appLanguage, preferredLanguage, and region + grand rename #153
Conversation
Please note that I found a
It's more common to place parameters used more often at the front though and ones that are usually skipped to fall back to the default values at the end. So I changed the order as follows (basically switched 2 and 4):
To still provide fix-its for most cases, I added a copy of the function which only takes the Signal Name and Parameters and made sure it's favored over the function with more parameters if only 2 are provided. Otherwise, Xcode is unable to apply fix-its when the order of parameters change, but I think fix-its can be really useful to save time in migration. |
I just updated this with a few bug fixes from my full setup testing. Biggest change is the addition of a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, I appreciate the docs a lot!
Seems like the linter is failing but from the error message it's not something introduced in this PR |
@winsmith I think it's related to the upgrade to Swift 5.9 to properly support the visionOS platform in the Package manifest. That requires Xcode 15, and the CI has Xcode 14. |
01e1850
to
23b957f
Compare
23b957f
to
3a45e61
Compare
@winsmith I just adjusted the CI configuration and fixed all tests and more. Here's all I did:
Please take another look. |
This is a follow-up on #149 with the branch renamed to
grand-rename
and the decisions from TelemetryDeck/docs#85 applied. This includes the changes from #149:In addition, I have renamed
TelemetryManager.send("A", with: ["a": "b"])
toTelemetryDeck.signal("A", parameters: ["a": "b"])
as well asTelemetryManager.initialize
toTelemetryDeck.initialize
as per TelemetryDeck/docs#85 (comment).