Added iPadOS to platform and operatingSystem in standard signal #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not testet though.
Jeehut
requested changes
Dec 2, 2024
There was a problem hiding this comment.
This looks good to me, except there are some weird indentation differences between all the return statements. Each of them is indented differently. Please fix, then this is good to go from my point of view.
Also please make sure to check if you get any Swift 6 warnings. Because I think accessing UIDevice.current is only possible from the @mainactor, and we already support Swift 6, so you might need to adjust more code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not testet though.