-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing parameters for navigation signals #219
Comments
@kkostov In #196 (released with version config.defaultParameters = {
[
"TelemetryDeck.SDK.dartVersion": "<your value>",
"TelemetryDeck.SDK.name": "<your value>",
"TelemetryDeck.SDK.version": "<your value>",
"TelemetryDeck.SDK.nameAndVersion": "<your value>",
]
} The internal sending logic overrides any default parameters with user-provided values, so overriding existing fields should work as expected. And since it's implemented as a closure, it's also great to pass dynamic values inside, such as the users purchase state or anything that might change after app start. This should be a flexible solution covering above use case. By the way something you might want to consider introducing in other SDKs, too as a convenience method (if you don't have something similar already). Does that work for you? |
Oh this is perfect! I will make use of that approach (and also add support for default parameters in the other two SDKs!) |
When the Flutter SDK invokes the native SDK on each platform, it includes additional default parameters to describe the SDK version. For example, it would replace the following:
TelemetryDeck.SDK.name
TelemetryDeck.SDK.version
TelemetryDeck.SDK.nameAndVersion
and append the following:
TelemetryDeck.SDK.dartVersion
Currently, this is not possible for navigation related events as they don't have a
parameters
options (TelemetryDeck/FlutterSDK#22).Please expand the API to allow parameters to be passed for such functions. As an alternative, the parameter overrides may also be provided as part of the start configuration (whichever makes more sense and feels better as an API).
This applies to all managed methods which generate signals internally.
The text was updated successfully, but these errors were encountered: