-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a way to automatically send a path when a new screen appears #184
Comments
@winsmith I played around with different approaches regarding simplifying navigation tracking in SwiftUI apps. My thoughts:
So I've implemented point 1, but I'm hesitant to implement any of the others without yours consent. If you think the trade-offs I've described above are worth the extra work, I can tackle them, too. But I personally think we have other areas we should focus on improving first. |
@Jeehut @winsmith does something similar make sense for the other SDKs? e.g. for navigation:
TelemetryDeckTracker("SignalMyComponentShown") {
// ... the rest of the composable ..
}
Button(
modifier = Modifiers.TelemetryDeck.signal("AddToBasked"),
onClick = { ... }
) {
Text("Add to basket")
} |
@kkostov I think it makes sense to make it easier on other platforms as well to track the navigation path. As outlined above though, I'm not sure if "automating" is a good idea as there's no clear way to do that, at least on iOS. Maybe things look different on other platforms. |
On Android and Flutter we have a way of globally tracking navigation lifecycle events with a listener, but you're right about automating it - it's better to leave it as an opt-in via configuration (e.g. setting a flag when starting For Flutter, it will be nice to also have #219 as part of the call to |
navigate(to:)
Ideas
@TelemetryScreen
The text was updated successfully, but these errors were encountered: