Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Grand Rename to v3 #38

Merged
merged 24 commits into from
Nov 25, 2024

Conversation

kkostov
Copy link
Contributor

@kkostov kkostov commented Sep 12, 2024

This PR fixes #37

The README has been updated with a migration guide for existing users.

The rest of the README has been updated to match the new API.

@kkostov kkostov changed the base branch from main to feat/adapt-release-for-maven-central September 12, 2024 10:14
@kkostov kkostov requested a review from winsmith October 4, 2024 18:58
@kkostov kkostov self-assigned this Oct 4, 2024
@kkostov kkostov marked this pull request as ready for review October 4, 2024 18:59
@kkostov
Copy link
Contributor Author

kkostov commented Oct 16, 2024

@winsmith, if you want to have a look before merging, please feel free to do so!

Copy link
Contributor

@winsmith winsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the very detailed documentation, and the code looks clean and usable. Apologies for the ultra late review, but I hereby approve it and you may merge & release at will!

@kkostov kkostov merged commit 094b616 into feat/adapt-release-for-maven-central Nov 25, 2024
1 check passed
@kkostov kkostov deleted the feat/grand-rename branch November 25, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants