Merge pull request #25 from thegrizzlylabs/add-app-build-number

feat(Environment) Add app build number to signal payload
TelemetryDeck · May 7, 2024 · 08fe243 · 08fe243
2 parents 2c4962e + fb23322
commit 08fe243
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/lib/src/main/java/com/telemetrydeck/sdk/EnvironmentMetadataProvider.kt b/lib/src/main/java/com/telemetrydeck/sdk/EnvironmentMetadataProvider.kt
@@ -17,6 +17,9 @@ class EnvironmentMetadataProvider : TelemetryProvider {
             if (!appVersion.isNullOrEmpty()) {
                 metadata["appVersion"] = appVersion
             }
+            ManifestMetadataReader.getBuildNumber(ctx)?.let { buildNumber ->
+                metadata["buildNumber"] = buildNumber.toString()
+            }
         } else {
             manager.logger?.error("EnvironmentMetadataProvider requires a context but received null. Signals will contain incomplete metadata.")
         }
@@ -73,4 +76,4 @@ class EnvironmentMetadataProvider : TelemetryProvider {
         }
         return signalPayload
     }
-}
+}
diff --git a/lib/src/main/java/com/telemetrydeck/sdk/ManifestMetadataReader.kt b/lib/src/main/java/com/telemetrydeck/sdk/ManifestMetadataReader.kt
@@ -2,8 +2,10 @@ package com.telemetrydeck.sdk
 
 import android.content.Context
 import android.content.pm.ApplicationInfo
+import android.content.pm.PackageInfo
 import android.content.pm.PackageManager
 import android.os.Bundle
+import androidx.core.content.pm.PackageInfoCompat
 import java.net.URL
 import java.util.*
 
@@ -19,13 +21,20 @@ internal class ManifestMetadataReader {
         }
 
         fun getAppVersion(context: Context): String? {
-            try {
-                val packageInfo = context.packageManager.getPackageInfo(context.packageName, 0)
-                return packageInfo.versionName
+            return getPackageInfo(context)?.versionName
+        }
+
+        fun getBuildNumber(context: Context): Long? {
+            return getPackageInfo(context)?.let { PackageInfoCompat.getLongVersionCode(it) }
+        }
+
+        private fun getPackageInfo(context: Context): PackageInfo? {
+            return try {
+                 context.packageManager.getPackageInfo(context.packageName, 0)
             } catch (e: PackageManager.NameNotFoundException) {
                 e.printStackTrace()
+                null
             }
-            return null
         }
 
         private fun getMetaData(context: Context): Bundle? {
@@ -82,4 +91,3 @@ internal class ManifestMetadataReader {
         }
     }
 }
-