Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 13593 unify id button #291

Draft
wants to merge 2 commits into
base: feature_branch/unify_ids
Choose a base branch
from

Conversation

DevPabloGarcia
Copy link
Contributor

πŸ₯… What's the goal?

❗ About 20 files are only import changes ❗

Unify Button element Ids

  • button
  • button_text
  • button_text_loading
  • button_progress
  • button_icon

We found a problem with xml element. We can reach icon and text subelement in order to set the new ids.
This way, we changed this element to wrap the compose id.

🚧 How do we do it?

  • Delete Button and ProgressButton element
  • Wrap Compose Button in new XML Button
  • Change all instances of old buttons/progress button to use new Button element

β˜‘οΈ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, update UPGRADING.md to inform users how to proceed. If no updates are necessary, indicate so.
  • Tested with dark mode.
  • Tested with API 23.

πŸ§ͺ How can I test this?

If it cannot be tested explain why.

  • πŸ–ΌοΈ Screenshots/Videos
  • Mistica App QR or download link
  • Reviewed by Mistica design team
  • ...

@DevPabloGarcia DevPabloGarcia changed the base branch from main to feature_branch/unify_ids July 28, 2023 13:07
@github-actions
Copy link

πŸ“± New catalog for testing generated: Download

@github-actions
Copy link

πŸ“± New catalog for testing generated: Download

@DevPabloGarcia DevPabloGarcia marked this pull request as draft August 9, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant